toanhoang/ubi-dan-itam
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: change Assignment.assetItemId/licenseId FK onDelete to RESTRICT

Browse Source 
Was implicitly SET NULL (Prisma default for nullable FK columns),
inconsistent with employeeId's RESTRICT. Once a delete endpoint for
AssetItem/License exists, SET NULL would silently null out historical
Assignment rows on delete, erasing what was assigned and re-violating
the assetItemId/licenseId XOR retroactively. No delete endpoint exists
yet, so no real data was ever affected by the old behavior.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
This commit is contained in:
toanhoang
2026-08-04 06:41:13 -04:00
co-authored by Claude Sonnet 5
parent be47eb69d3
commit b702528e19
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
prisma/migrations/20260804103916_assignment_fk_restrict/migration.sql
+11
View File
@@ -0,0 +1,11 @@
-- DropForeignKey
ALTER TABLE "assignments" DROP CONSTRAINT "assignments_asset_item_id_fkey";
-- DropForeignKey
ALTER TABLE "assignments" DROP CONSTRAINT "assignments_license_id_fkey";
-- AddForeignKey
ALTER TABLE "assignments" ADD CONSTRAINT "assignments_asset_item_id_fkey" FOREIGN KEY ("asset_item_id") REFERENCES "asset_items"("id") ON DELETE RESTRICT ON UPDATE CASCADE;
-- AddForeignKey
ALTER TABLE "assignments" ADD CONSTRAINT "assignments_license_id_fkey" FOREIGN KEY ("license_id") REFERENCES "licenses"("id") ON DELETE RESTRICT ON UPDATE CASCADE;
prisma/schema.prisma
+2 -2
View File
@@ -398,9 +398,9 @@ model Assignment {
employeeId String @map("employee_id") @db.Uuid
employee Employee @relation(fields: [employeeId], references: [id])
assetItemId String? @map("asset_item_id") @db.Uuid
assetItem AssetItem? @relation(fields: [assetItemId], references: [id])
assetItem AssetItem? @relation(fields: [assetItemId], references: [id], onDelete: Restrict)
licenseId String? @map("license_id") @db.Uuid
license License? @relation(fields: [licenseId], references: [id])
license License? @relation(fields: [licenseId], references: [id], onDelete: Restrict)
assignedAt DateTime @default(now()) @map("assigned_at") @db.Timestamptz(6)
returnedAt DateTime? @map("returned_at") @db.Timestamptz(6)
signedAt DateTime? @map("signed_at") @db.Timestamptz(6)